8387334: IR Framework tests should run in jtreg driver mode#31694
8387334: IR Framework tests should run in jtreg driver mode#31694TobiHartmann wants to merge 8 commits into
Conversation
|
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@TobiHartmann The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
| // TODO 8387402 | ||
| //@IR(applyIfCPUFeatureOr = {"asimd", "true", "sse2", "true", "rvv", "true"}, | ||
| // applyIf = {"OptimizeFill", "false"}, | ||
| // counts = {IRNode.REPLICATE_B, ">0"}) |
Webrevs
|
chhagedorn
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up, looks good to me!
…tFillTest.java Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
…tFillTest.java Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
…pTest.java Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
|
Thanks for the review Christian! |
When working on JDK-8381693, I noticed that some IR Framework tests in mainline are not executed in jtreg driver mode although they could. I fixed that and also removed useless
@buildstatements and WhiteBox API includes.I also noticed that a few of the vector tests using the
VectorizationTestRunnerframework likeArrayInvariantFillTest.javadid not correctly pass VM arguments to the IR framework's Test VM. I fixed that and filed JDK-8387402 as follow-up. Running those tests in driver mode also required getting rid of the WhiteBox API usages. I modifiedVectorizationTestRunner.javato run the correctness tests in a separate VM.The main advantage of this change is that the IR framework itself is not affected by expensive VM flags like
-Xcompanymore.Thanks,
Tobias
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31694/head:pull/31694$ git checkout pull/31694Update a local copy of the PR:
$ git checkout pull/31694$ git pull https://git.openjdk.org/jdk.git pull/31694/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31694View PR using the GUI difftool:
$ git pr show -t 31694Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31694.diff
Using Webrev
Link to Webrev Comment