Skip to content

8387334: IR Framework tests should run in jtreg driver mode#31694

Open
TobiHartmann wants to merge 8 commits into
openjdk:masterfrom
TobiHartmann:JDK-8387334
Open

8387334: IR Framework tests should run in jtreg driver mode#31694
TobiHartmann wants to merge 8 commits into
openjdk:masterfrom
TobiHartmann:JDK-8387334

Conversation

@TobiHartmann

@TobiHartmann TobiHartmann commented Jun 26, 2026

Copy link
Copy Markdown
Member

When working on JDK-8381693, I noticed that some IR Framework tests in mainline are not executed in jtreg driver mode although they could. I fixed that and also removed useless @build statements and WhiteBox API includes.

I also noticed that a few of the vector tests using the VectorizationTestRunner framework like ArrayInvariantFillTest.java did not correctly pass VM arguments to the IR framework's Test VM. I fixed that and filed JDK-8387402 as follow-up. Running those tests in driver mode also required getting rid of the WhiteBox API usages. I modified VectorizationTestRunner.java to run the correctness tests in a separate VM.

The main advantage of this change is that the IR framework itself is not affected by expensive VM flags like -Xcomp anymore.

Thanks,
Tobias



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8387334: IR Framework tests should run in jtreg driver mode (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31694/head:pull/31694
$ git checkout pull/31694

Update a local copy of the PR:
$ git checkout pull/31694
$ git pull https://git.openjdk.org/jdk.git pull/31694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31694

View PR using the GUI difftool:
$ git pr show -t 31694

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31694.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 26, 2026

Copy link
Copy Markdown

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 26, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title JDK-8387334 8387334: IR Framework tests should run in jtreg driver mode. Jun 26, 2026
@openjdk openjdk Bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 26, 2026
@openjdk

openjdk Bot commented Jun 26, 2026

Copy link
Copy Markdown

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jun 26, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

@TobiHartmann TobiHartmann changed the title 8387334: IR Framework tests should run in jtreg driver mode. 8387334: IR Framework tests should run in jtreg driver mode Jun 26, 2026
// TODO 8387402
//@IR(applyIfCPUFeatureOr = {"asimd", "true", "sse2", "true", "rvv", "true"},
// applyIf = {"OptimizeFill", "false"},
// counts = {IRNode.REPLICATE_B, ">0"})

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled until JDK-8387402 is fixed.

@TobiHartmann TobiHartmann marked this pull request as ready for review June 29, 2026 11:34
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 29, 2026
@mlbridge

mlbridge Bot commented Jun 29, 2026

Copy link
Copy Markdown

Webrevs

@chhagedorn chhagedorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, looks good to me!

Comment thread test/hotspot/jtreg/compiler/vectorization/runner/ArrayInvariantFillTest.java Outdated
Comment thread test/hotspot/jtreg/compiler/vectorization/runner/ArrayInvariantFillTest.java Outdated
Comment thread test/hotspot/jtreg/compiler/vectorization/runner/StripMinedLoopTest.java Outdated
TobiHartmann and others added 3 commits June 29, 2026 14:13
…tFillTest.java

Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
…tFillTest.java

Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
…pTest.java

Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
@TobiHartmann

Copy link
Copy Markdown
Member Author

Thanks for the review Christian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants