8380750: Test runtime/cds/appcds/TestSerialGCWithCDS.java#id1 failed: StringIndexOutOfBoundsException

[matias9927]

This test was failing with this error:
java.lang.StringIndexOutOfBoundsException: Range [3973, 3) out of bounds for length 4540
due to an issue with getCrashMessage in CDSTestUtils. It is possible for the hserr log file to not be present with errors like OOME, so this had to be refactored to check for a more reliably present part of the error message. Verifed with tier 1-5 tests.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8380750: Test runtime/cds/appcds/TestSerialGCWithCDS.java#id1 failed: StringIndexOutOfBoundsException (Bug - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31698/head:pull/31698
$ git checkout pull/31698

Update a local copy of the PR:
$ git checkout pull/31698
$ git pull https://git.openjdk.org/jdk.git pull/31698/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31698

View PR using the GUI difftool:
$ git pr show -t 31698

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31698.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@matias9927 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 01: Full - Incremental (21816641)
• 00: Full (49a771a5)

[coleenp]

This makes sense. Looks good and trivial.