Skip to content

8377980: Add methods returning Instant instead of Date to X509CRL and X509CRLEntry#31700

Open
myankelev wants to merge 1 commit into
openjdk:masterfrom
myankelev:JDK-8377980
Open

8377980: Add methods returning Instant instead of Date to X509CRL and X509CRLEntry#31700
myankelev wants to merge 1 commit into
openjdk:masterfrom
myankelev:JDK-8377980

Conversation

@myankelev

@myankelev myankelev commented Jun 27, 2026

Copy link
Copy Markdown
Member

Introducing Instant returning methods in the public api to similar to X509Certificate:

  • X509CRL: getThisUpdate, getNextUpdate
  • X509CRLEntry: getRevocationDate

Please note, this pr only changes public api with internals changed as a separate pr due to overlap with other implementations in the queue for a Date to Instant change



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8387373 to be approved

Issues

  • JDK-8377980: Add methods returning Instant instead of Date to X509CRL and X509CRLEntry (Enhancement - P4)
  • JDK-8387373: Add methods returning Instant instead of Date to X509CRL and X509CRLEntry (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31700/head:pull/31700
$ git checkout pull/31700

Update a local copy of the PR:
$ git checkout pull/31700
$ git pull https://git.openjdk.org/jdk.git pull/31700/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31700

View PR using the GUI difftool:
$ git pr show -t 31700

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31700.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 27, 2026

Copy link
Copy Markdown

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 27, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title JDK-8377980: Add methods returning Instant instead of Date to X509CRL and X509CRLEntry 8377980: Add methods returning Instant instead of Date to X509CRL and X509CRLEntry Jun 27, 2026
@openjdk openjdk Bot added the security security-dev@openjdk.org label Jun 27, 2026
@openjdk

openjdk Bot commented Jun 27, 2026

Copy link
Copy Markdown

@myankelev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 27, 2026
@mlbridge

mlbridge Bot commented Jun 27, 2026

Copy link
Copy Markdown

Webrevs

@openjdk

openjdk Bot commented Jun 27, 2026

Copy link
Copy Markdown

@myankelev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk Bot added the csr Pull request needs approved CSR before integration label Jun 27, 2026
@myankelev myankelev marked this pull request as draft June 27, 2026 11:19
@openjdk openjdk Bot removed the rfr Pull request is ready for review label Jun 27, 2026
@myankelev myankelev marked this pull request as ready for review June 27, 2026 11:23
@myankelev

Copy link
Copy Markdown
Member Author

Just updated copyright notice since the previous one was unusual for the package. I'm not sure which one i have to use since I never knew that there were several. Please let me know if I have to update it

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

csr Pull request needs approved CSR before integration rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant