8377980: Add methods returning Instant instead of Date to X509CRL and X509CRLEntry#31700
8377980: Add methods returning Instant instead of Date to X509CRL and X509CRLEntry#31700myankelev wants to merge 1 commit into
Conversation
|
👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@myankelev The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
@myankelev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
… and X509CRLEntry
|
Just updated copyright notice since the previous one was unusual for the package. I'm not sure which one i have to use since I never knew that there were several. Please let me know if I have to update it |
Introducing Instant returning methods in the public api to similar to X509Certificate:
Please note, this pr only changes public api with internals changed as a separate pr due to overlap with other implementations in the queue for a
DatetoInstantchangeProgress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31700/head:pull/31700$ git checkout pull/31700Update a local copy of the PR:
$ git checkout pull/31700$ git pull https://git.openjdk.org/jdk.git pull/31700/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31700View PR using the GUI difftool:
$ git pr show -t 31700Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31700.diff
Using Webrev
Link to Webrev Comment