Skip to content

8387375: Update package sun.font to use instanceof pattern variable#31702

Open
gredler wants to merge 3 commits into
openjdk:masterfrom
gredler:JDK-8387375
Open

8387375: Update package sun.font to use instanceof pattern variable#31702
gredler wants to merge 3 commits into
openjdk:masterfrom
gredler:JDK-8387375

Conversation

@gredler

@gredler gredler commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Update code in the package sun.font to make use of the instanceof pattern variable. Includes equals methods and a few methods using ClassCastException for flow control.

While looking through this code, I've noticed a few pre-existing suspicious differences between equals and hashCode implementations, but have not made any functional changes to fix this (best to address separately, if needed).

Tests checked locally on Linux, Windows and macOS:

  • make test TEST="jtreg:test/jdk/java/awt/font"
  • make test TEST="jtreg:test/jdk/java/awt/Graphics2D/DrawString"


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8387375: Update package sun.font to use instanceof pattern variable (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31702/head:pull/31702
$ git checkout pull/31702

Update a local copy of the PR:
$ git checkout pull/31702
$ git pull https://git.openjdk.org/jdk.git pull/31702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31702

View PR using the GUI difftool:
$ git pr show -t 31702

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31702.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 28, 2026

Copy link
Copy Markdown

👋 Welcome back dgredler! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 28, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the client client-libs-dev@openjdk.org label Jun 28, 2026
@openjdk

openjdk Bot commented Jun 28, 2026

Copy link
Copy Markdown

@gredler The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jun 28, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: client. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 28, 2026
@mlbridge

mlbridge Bot commented Jun 28, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant