Skip to content

8387387: Parallel: Clean up startup allocation locking#31705

Open
albertnetymk wants to merge 1 commit into
openjdk:masterfrom
albertnetymk:pgc-init-followup
Open

8387387: Parallel: Clean up startup allocation locking#31705
albertnetymk wants to merge 1 commit into
openjdk:masterfrom
albertnetymk:pgc-init-followup

Conversation

@albertnetymk

@albertnetymk albertnetymk commented Jun 29, 2026

Copy link
Copy Markdown
Member

Simple cleanup in ParallelScavengeHeap::mem_allocate_work, which restructures the pre-initialization heap expansion check to use ConditionalMutexLocker for InitCompleted_lock, matching the nearby Heap_lock pattern, and polishes the comments around the locking invariant. There is no intended behavior change.

Test: tier1



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8387387: Parallel: Clean up startup allocation locking (Enhancement - P4)

Reviewers

Contributors

  • Axel Boldt-Christmas <aboldtch@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31705/head:pull/31705
$ git checkout pull/31705

Update a local copy of the PR:
$ git checkout pull/31705
$ git pull https://git.openjdk.org/jdk.git pull/31705/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31705

View PR using the GUI difftool:
$ git pr show -t 31705

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31705.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 29, 2026

Copy link
Copy Markdown

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@albertnetymk albertnetymk changed the title pgc-init-followup 8387387 Jun 29, 2026
@openjdk openjdk Bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

@openjdk openjdk Bot changed the title 8387387 8387387: Parallel: Clean up startup allocation locking Jun 29, 2026
@albertnetymk

Copy link
Copy Markdown
Member Author

/contributor add aboldtch

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

@albertnetymk
Contributor Axel Boldt-Christmas <aboldtch@openjdk.org> successfully added.

@mlbridge

mlbridge Bot commented Jun 29, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants