8387391: hotspot_gc_shenandoah should include gtests#31706
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
|
GHA failure is going to get resolved by: #31707 |
There are some Shenandoah gtests, but they are not included in our standard hotspot_gc_shenandoah that we use for sanity checks. We need to add Shenandoah gtests to hotspot_gc_shenandoah.
Additional testing:
hotspot_gc_shenandoahProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31706/head:pull/31706$ git checkout pull/31706Update a local copy of the PR:
$ git checkout pull/31706$ git pull https://git.openjdk.org/jdk.git pull/31706/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31706View PR using the GUI difftool:
$ git pr show -t 31706Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31706.diff
Using Webrev
Link to Webrev Comment