Skip to content

8387391: hotspot_gc_shenandoah should include gtests#31706

Open
shipilev wants to merge 2 commits into
openjdk:masterfrom
shipilev:JDK-8387391-hotspot-gc-shenandoah-gtests
Open

8387391: hotspot_gc_shenandoah should include gtests#31706
shipilev wants to merge 2 commits into
openjdk:masterfrom
shipilev:JDK-8387391-hotspot-gc-shenandoah-gtests

Conversation

@shipilev

@shipilev shipilev commented Jun 29, 2026

Copy link
Copy Markdown
Member

There are some Shenandoah gtests, but they are not included in our standard hotspot_gc_shenandoah that we use for sanity checks. We need to add Shenandoah gtests to hotspot_gc_shenandoah.

Additional testing:

  • Sanity-checking the test reports with hotspot_gc_shenandoah


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8387391: hotspot_gc_shenandoah should include gtests (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31706/head:pull/31706
$ git checkout pull/31706

Update a local copy of the PR:
$ git checkout pull/31706
$ git pull https://git.openjdk.org/jdk.git pull/31706/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31706

View PR using the GUI difftool:
$ git pr show -t 31706

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31706.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 29, 2026

Copy link
Copy Markdown

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8387391: hotspot_gc_shenandoah should include gtests

Reviewed-by: xpeng, kdnilsen, wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added the hotspot hotspot-dev@openjdk.org label Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 29, 2026
@mlbridge

mlbridge Bot commented Jun 29, 2026

Copy link
Copy Markdown

Webrevs

@shipilev

Copy link
Copy Markdown
Member Author

GHA failure is going to get resolved by: #31707

@pengxiaolong pengxiaolong left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kdnilsen kdnilsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

4 participants