Skip to content

8387258: Test jdk/jfr/event/runtime/TestResidentSetSizeEvent.java failed on Windows: The size should be less than or equal to peak#31708

Open
tschatzl wants to merge 1 commit into
openjdk:masterfrom
tschatzl:submit/8387258-windows-rss-cur-peak
Open

8387258: Test jdk/jfr/event/runtime/TestResidentSetSizeEvent.java failed on Windows: The size should be less than or equal to peak#31708
tschatzl wants to merge 1 commit into
openjdk:masterfrom
tschatzl:submit/8387258-windows-rss-cur-peak

Conversation

@tschatzl

@tschatzl tschatzl commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hi all,

please review this small fix to avoid inconsistencies with Windows' RSS current/peak usage.

The documentation for this function does not mention any kind of consistency guarantee, so apply the same fix as for all other OSes in that area.

Testing: gha

Thanks,
Thomas



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8387258: Test jdk/jfr/event/runtime/TestResidentSetSizeEvent.java failed on Windows: The size should be less than or equal to peak (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31708/head:pull/31708
$ git checkout pull/31708

Update a local copy of the PR:
$ git checkout pull/31708
$ git pull https://git.openjdk.org/jdk.git pull/31708/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31708

View PR using the GUI difftool:
$ git pr show -t 31708

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31708.diff

Using Webrev

Link to Webrev Comment

Hi all,

  please review this small fix to avoid inconsistencies with Windows' RSS current/peak usage.

The documentation for this function does not mention any kind of consistency guarantee, so apply the same fix as for all other OSes in that area.

Testing: gha

Thanks,
  Thomas
@bridgekeeper

bridgekeeper Bot commented Jun 29, 2026

Copy link
Copy Markdown

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title 8387258 8387258: Test jdk/jfr/event/runtime/TestResidentSetSizeEvent.java failed on Windows: The size should be less than or equal to peak Jun 29, 2026
@openjdk openjdk Bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

@tschatzl tschatzl marked this pull request as ready for review June 29, 2026 13:21
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 29, 2026
@mlbridge

mlbridge Bot commented Jun 29, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant