Skip to content

8387446: Obsolete vtableStubs.hpp comments#31718

Open
benjaminp wants to merge 1 commit into
openjdk:masterfrom
benjaminp:stub-comments
Open

8387446: Obsolete vtableStubs.hpp comments#31718
benjaminp wants to merge 1 commit into
openjdk:masterfrom
benjaminp:stub-comments

Conversation

@benjaminp

@benjaminp benjaminp commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Comments in vtableStubs.hpp said that there's a stub for (index, #args) pairs. It would be more accurate today to characterize it as a stub per (type, index) pair.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8387446: Obsolete vtableStubs.hpp comments (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31718/head:pull/31718
$ git checkout pull/31718

Update a local copy of the PR:
$ git checkout pull/31718
$ git pull https://git.openjdk.org/jdk.git pull/31718/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31718

View PR using the GUI difftool:
$ git pr show -t 31718

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31718.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 29, 2026

Copy link
Copy Markdown

👋 Welcome back bpeterson! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

@benjaminp The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 29, 2026
@benjaminp benjaminp changed the title 8387446: obsolete vtableStubs.hpp comments 8387446: Obsolete vtableStubs.hpp comments Jun 29, 2026
@mlbridge

mlbridge Bot commented Jun 29, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant