8387446: Obsolete vtableStubs.hpp comments#31718
Conversation
|
👋 Welcome back bpeterson! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@benjaminp The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Comments in
vtableStubs.hppsaid that there's a stub for(index, #args)pairs. It would be more accurate today to characterize it as a stub per(type, index)pair.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31718/head:pull/31718$ git checkout pull/31718Update a local copy of the PR:
$ git checkout pull/31718$ git pull https://git.openjdk.org/jdk.git pull/31718/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31718View PR using the GUI difftool:
$ git pr show -t 31718Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31718.diff
Using Webrev
Link to Webrev Comment