8367348: Enhance PassFailJFrame to support links in HTML

[TheMangovnik]

Backport of JDK-8367348 - Enhance PassFailJFrame to support links in HTML. Tests become more interactive if users can click links in the instructions and handle them with their own HyperlinkListener.

This backport is in follow up to the backport of JDK-8213781 (this PR).

There are two differences compared to the corresponding backport to jdk17

• The change to comment block was omitted because the comment block differ quite a bit between current jdk11 and jdk17 versions, hence it is not clear if and where this change should be integrated.
• This if uses pattern matching for instanceof, which is a feature that is not supported by jdk11, hence I edited this to be jdk11 compatible.

// version in jdk17
if (hyperlinkListener != null && text instanceof JEditorPane ep) {
    ep.addHyperlinkListener(hyperlinkListener);
}

// version in this backport
if (hyperlinkListener != null && text instanceof JEditorPane) {
    ((JEditorPane) text).addHyperlinkListener(hyperlinkListener);
}

Tests

Testing was done on Fedora 43.

Tier 1 - PASSES

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/hotspot/jtreg:tier1                     1497  1497     0     0
   jtreg:test/jdk:tier1                               1900  1900     0     0
   jtreg:test/langtools:tier1                         3940  3940     0     0
   jtreg:test/nashorn:tier1                              0     0     0     0
   jtreg:test/jaxp:tier1                                 0     0     0     0
==============================
TEST SUCCESS

GTest - PASSES

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   gtest:all/server                                    504   504     0     0
==============================
TEST SUCCESS

GHA - PASSES

macos-x64 hs/tier1 serviceability is failing, but this seems to be common over other unrelated PRs too -> not relevant to this backport.

Bonus tests - PASSES

I identified following interactive tests that are affected by this backport that seems to be behaving the same way before and after this backport:

• test/jdk/java/awt/font/TextLayout/ArabicBox.java
• test/jdk/java/awt/font/TextLayout/TestJustification.java
• test/jdk/java/awt/Frame/ALTTABIconBeingErased/ALTTABIconBeingErased.java
• test/jdk/java/awt/Frame/DefaultSizeTest.java
• test/jdk/java/awt/Frame/GetBoundsResizeTest.java
• test/jdk/java/awt/geom/HitTest/PathHitTest.java
• test/jdk/java/awt/Icon/IconChangingTest/IconChangingTest.java
• test/jdk/java/awt/Icon/IconShowingTest/IconShowingTest.java
• test/jdk/java/awt/Icon/IconTransparencyTest/IconTransparencyTest.java
• test/jdk/java/awt/Icon/SetLargeIconTest/SetLargeIconTest.java
• test/jdk/java/awt/LightweightComponent/LightweightCliprect.java
• test/jdk/java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_1.java
• test/jdk/java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_2.java
• test/jdk/java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_3.java
• test/jdk/java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_4.java
• test/jdk/java/awt/PopupMenu/TruncatedPopupMenuTest.java
• test/jdk/java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java
• test/jdk/java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java
• test/jdk/java/awt/print/PrinterJob/PageRangesDlgTest.java
• test/jdk/java/awt/print/PrinterJob/PrintGlyphVectorTest.java
• test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java
• test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java
• test/jdk/javax/accessibility/TestJMenuItemShortcutAccessibility.java
• test/jdk/javax/swing/JComboBox/JComboBoxActionEvent.java
• test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java
• test/jdk/javax/swing/JFrame/bug4419914.java
• test/jdk/javax/swing/JFrame/DefaultCloseOperation.java
• test/jdk/javax/swing/JMenuItem/TestRadioAndCheckMenuItemWithIcon.java
• test/jdk/javax/swing/JRadioButton/bug4380543.java
• test/jdk/javax/swing/JTabbedPane/4209065/bug4209065.java
• test/jdk/javax/swing/JToolBar/bug4203039.java
• test/jdk/javax/swing/MultiMonitor/MultimonVImage.java
• test/jdk/javax/swing/ProgressMonitor/ProgressTest.java
• test/jdk/javax/swing/text/bug4148489.java
• test/jdk/javax/swing/text/html/StyleSheet/bug4803145.java
• test/jdk/javax/swing/text/PaintTest.java
• test/jdk/sun/awt/PaletteTester.java

---

Bonus info

This PR may not be the best place to mention this, but since I have no idea where other place to bring this up:

While trying to run the interactive tests mentioned above I find out that few of them are unable to compile, since they make use of """ for string block, which is a feature that is not supported by jdk11. The tests that this applies to:

• GetBoundsResizeTest.java
• AddRemoveMenuBarTest_1.java
• AddRemoveMenuBarTest_2.java
• AddRemoveMenuBarTest_3.java
• AddRemoveMenuBarTest_4.java

Out of curiosity I searched the jdk11 repo and found one more test that also uses """:

• test/jdk/sun/awt/PaletteTester.java

Looking into other tests from above that also failed:

• JComboBoxBorderTest.java -> seems to be macos specific test that is being executed on Linux too, because it misses corresponding annotation to be run only on mac.
• TestJustification.java also seems to be failing on Linux, but in test/jdk/ProblemList.txt it is mention only as mac specific.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8367348 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8367348: Enhance PassFailJFrame to support links in HTML (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3147/head:pull/3147
$ git checkout pull/3147

Update a local copy of the PR:
$ git checkout pull/3147
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3147

View PR using the GUI difftool:
$ git pr show -t 3147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3147.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back TheMangovnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (e1f226c1)

[gnu-andrew]

It looks like we should backport the resolved subtasks of JDK-8318688 first before this change, particularly 8340785: Update description of PassFailJFrame and samples and 8350260: Improve HTML instruction formatting in PassFailJFrame. The former adds in the documentation you couldn't find and the latter resolves the difference in the styles.addRule line. With those, it would leave the only difference as the instanceof change (which looks correct)

[TheMangovnik]

So:

• All of the resolved subtasks from JDK-8318688 before this one?
• Or only the two you pointed out before this one and the remaining from JDK-8318688 at any unrelated point?

However, this is for after CPU neither way, since all of them have P4, right?

[gnu-andrew]

So:

* All of the resolved subtasks from [JDK-8318688](https://bugs.openjdk.org/browse/JDK-8318688) before this one?

* Or only the two you pointed out before this one and the remaining from [JDK-8318688](https://bugs.openjdk.org/browse/JDK-8318688) at any unrelated point?

Only the two are prerequisites for this change, as that should mean the hunk doesn't need to be dropped and this should be close to clean. The others I'll leave to you to pursue if you wish.

However, this is for after CPU neither way, since all of them have P4, right?

Yeah. 11u-dev is now taking changes for July.

[bridgekeeper]

@TheMangovnik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TheMangovnik]

/touch

[openjdk]

@TheMangovnik The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@TheMangovnik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TheMangovnik]

/touch

[TheMangovnik]

/template append

[openjdk]

@TheMangovnik The pull request is being re-evaluated and the inactivity timeout has been reset.

[openjdk]

@TheMangovnik The pull request template has been appended to the pull request body

[bridgekeeper]

@TheMangovnik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!