8385939: [11u] Remove arm64 port#3189
Draft
gnu-andrew wants to merge 3 commits into
Draft
Conversation
|
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDK-8168503 introduced an additional AArch64 port as part of the arm port opened up by Oracle in OpenJDK 9. This was later removed in JDK-8209093 as part of OpenJDK 12.
This leaves this unmaintained port in one LTS release, 11. The code does not build and, as far as I can see, has never been able to build as it contains references to
FloatRegisterSetwhich has been defined in assembler_arm_32.hpp since import.The prospect of removing it from 11u was raised when backporting the security issue, JDK-8364465. The presence of the arm64 port made it harder to apply the backported changes to the arm32 port and it was not possible to ascertain the need for changes in the arm64 port due to a lack of expertise with the port and the code not even building.
Leaving the unused code in the repository would be less of an issue if it was separated from the arm32 code. However, the presence of the port makes the arm32 port a mess of
ifdefs and so in turn makes that harder to maintain, and prone to problems such as backporting patches actually being applied to similar aarch64 code without realisation.Of course, this also makes it tricker to remove, but we do already have the patch from 12, and can perform additional verification with the C preprocessor. The fact that the removal patch applies cleanly to the arm64 only files shows how little has been touched since inclusion.
I'm creating this as a new bug as the removal, for some reason, is a JEP. I presume this was because of the work involved in testing the removal, but it is hardly an enhancement. I also believe the risk of removal is low, and will pay off over time.
Keeping this in draft while I verify changes further and we should also add JDK-8213204
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3189/head:pull/3189$ git checkout pull/3189Update a local copy of the PR:
$ git checkout pull/3189$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3189/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3189View PR using the GUI difftool:
$ git pr show -t 3189Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3189.diff