Skip to content

8385939: [11u] Remove arm64 port#3189

Draft
gnu-andrew wants to merge 3 commits into
openjdk:masterfrom
gnu-andrew:JDK-8209093
Draft

8385939: [11u] Remove arm64 port#3189
gnu-andrew wants to merge 3 commits into
openjdk:masterfrom
gnu-andrew:JDK-8209093

Conversation

@gnu-andrew

@gnu-andrew gnu-andrew commented Apr 30, 2026

Copy link
Copy Markdown
Member

JDK-8168503 introduced an additional AArch64 port as part of the arm port opened up by Oracle in OpenJDK 9. This was later removed in JDK-8209093 as part of OpenJDK 12.

This leaves this unmaintained port in one LTS release, 11. The code does not build and, as far as I can see, has never been able to build as it contains references to FloatRegisterSet which has been defined in assembler_arm_32.hpp since import.

The prospect of removing it from 11u was raised when backporting the security issue, JDK-8364465. The presence of the arm64 port made it harder to apply the backported changes to the arm32 port and it was not possible to ascertain the need for changes in the arm64 port due to a lack of expertise with the port and the code not even building.

Leaving the unused code in the repository would be less of an issue if it was separated from the arm32 code. However, the presence of the port makes the arm32 port a mess of ifdefs and so in turn makes that harder to maintain, and prone to problems such as backporting patches actually being applied to similar aarch64 code without realisation.

Of course, this also makes it tricker to remove, but we do already have the patch from 12, and can perform additional verification with the C preprocessor. The fact that the removal patch applies cleanly to the arm64 only files shows how little has been touched since inclusion.

I'm creating this as a new bug as the removal, for some reason, is a JEP. I presume this was because of the work involved in testing the removal, but it is hardly an enhancement. I also believe the risk of removal is low, and will pay off over time.

Keeping this in draft while I verify changes further and we should also add JDK-8213204



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8385939 needs maintainer approval

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3189/head:pull/3189
$ git checkout pull/3189

Update a local copy of the PR:
$ git checkout pull/3189
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3189

View PR using the GUI difftool:
$ git pr show -t 3189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3189.diff

@bridgekeeper

bridgekeeper Bot commented Apr 30, 2026

Copy link
Copy Markdown

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Apr 30, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 05027c124c62e23f010a3e8edb233ac50906d34f 8209093: JEP 340: One AArch64 Port, Not Two Apr 30, 2026
@openjdk

openjdk Bot commented Apr 30, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Apr 30, 2026
@gnu-andrew gnu-andrew changed the title 8209093: JEP 340: One AArch64 Port, Not Two 8385939: [11u] Remove arm64 port Jun 3, 2026
@openjdk

openjdk Bot commented Jun 3, 2026

Copy link
Copy Markdown

⚠️ @gnu-andrew This backport pull request is too large to be automatically evaluated as clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base

Development

Successfully merging this pull request may close these issues.

1 participant