8312620: WSL Linux build crashes after JDK-8310233#3194
Closed
tabata-d wants to merge 1 commit into
Closed
Conversation
|
👋 Welcome back dtabata! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
5 tasks
Member
Author
|
After the discussion in #3210, I have decided to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDK-8312620 is a bug fix that addresses a regression in Linux hugepage detection introduced by JDK-8310233. On WSL1, the kernel reports a non‑zero
Hugepagesizein/proc/meminfobut does not expose/sys/kernel/mm/hugepages, which causes the VM to hit an assertion inStaticHugePageSupport::scan_os()and crash when static hugepages are enabled (e.g., with-XX:+UseLargePages).The fix was originally implemented in JDK 22. Now we are backporting this into JDK 11. It is a clean Backport.
This change touches the same code as JDK-8312394(#3172) , which addresses a regression introduced by JDK-8310233. Therefore, JDK-8312394 needs to be integrated before this fix.
Testing
System: Ran on Red Hat Enterprise Linux 9.4 (x86_64).
jtreg: A comprehensive
jtregrun on the entirehotspot/jtregtest suite confirmed that all HotSpot tests passed.Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3194/head:pull/3194$ git checkout pull/3194Update a local copy of the PR:
$ git checkout pull/3194$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3194/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3194View PR using the GUI difftool:
$ git pr show -t 3194Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3194.diff
Using Webrev
Link to Webrev Comment