Skip to content

8257989: Error in gtest os_page_size_for_region_unaligned after 8257588#3195

Closed
tabata-d wants to merge 1 commit into
openjdk:pr/3160from
tabata-d:JDK-8257989
Closed

8257989: Error in gtest os_page_size_for_region_unaligned after 8257588#3195
tabata-d wants to merge 1 commit into
openjdk:pr/3160from
tabata-d:JDK-8257989

Conversation

@tabata-d

@tabata-d tabata-d commented May 12, 2026

Copy link
Copy Markdown
Member

The fix addresses an issue in the os_page_size_for_region_unaligned gtest, which was introduced by changes in JDK-8257588. The original test logic had an incorrect comparison, leading to test failures when multiple large page sizes were configured. This enhancement corrects the test logic to accurately verify the os::page_size_for_region_unaligned function.

We are backporting this fix from JDK 16 to JDK 11. It is a clean Backport.

Testing

The gtest suite, specifically the os tests, including os.page_size_for_region_unaligned_test_vm, passed successfully.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8257989 needs maintainer approval

Integration blocker

 ⚠️ Dependency #3160 must be integrated first

Issue

  • JDK-8257989: Error in gtest os_page_size_for_region_unaligned after 8257588 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3195/head:pull/3195
$ git checkout pull/3195

Update a local copy of the PR:
$ git checkout pull/3195
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3195

View PR using the GUI difftool:
$ git pr show -t 3195

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3195.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 12, 2026

Copy link
Copy Markdown

👋 Welcome back dtabata! A progress list of the required criteria for merging this PR into pr/3160 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 12, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title backport b977a7b8a52c0677f9dded90170116ebaa27f911 8257989: Error in gtest os_page_size_for_region_unaligned after 8257588 May 12, 2026
@openjdk

openjdk Bot commented May 12, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels May 12, 2026
@mlbridge

mlbridge Bot commented May 12, 2026

Copy link
Copy Markdown

Webrevs

@tabata-d

tabata-d commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

After the discussion in #3210, I have decided to close this PR.

@tabata-d tabata-d closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant