Skip to content

8372351: Add 2 WISeKey roots#3200

Closed
vieiro wants to merge 2 commits into
openjdk:masterfrom
vieiro:backports/JDK-8372351
Closed

8372351: Add 2 WISeKey roots#3200
vieiro wants to merge 2 commits into
openjdk:masterfrom
vieiro:backports/JDK-8372351

Conversation

@vieiro

@vieiro vieiro commented May 21, 2026

Copy link
Copy Markdown
Contributor

Backport of JDK-8372351 from JDK17, that adds two new CA root certificates, that should get into 2026-07.

Mostly clean but for CAInterop.java which is missing https://bugs.openjdk.org/browse/JDK-8328638 and https://bugs.openjdk.org/browse/JDK-8329213 from higher JDK versions. Also JDK11 is missing https://openjdk.org/jeps/361.

Security tests pass, but for a failure in PreferredKey due to an expired certificate as reported in https://bugs.openjdk.org/browse/JDK-8384815, which should be backported to JDK11 (currently under review in JDK17).

In particular the affected test passes:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java
                                                         1     1     0     0   
==============================
TEST SUCCESS


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372351 needs maintainer approval

Issue

  • JDK-8372351: Add 2 WISeKey roots (Enhancement - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3200/head:pull/3200
$ git checkout pull/3200

Update a local copy of the PR:
$ git checkout pull/3200
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3200

View PR using the GUI difftool:
$ git pr show -t 3200

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3200.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 21, 2026

Copy link
Copy Markdown

👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 21, 2026

Copy link
Copy Markdown

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8372351: Add 2 WISeKey roots

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport ccb57972f4b73bd8320e9944ca081d933f47aae8 8372351: Add 2 WISeKey roots May 21, 2026
@openjdk

openjdk Bot commented May 21, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 21, 2026
@mlbridge

mlbridge Bot commented May 21, 2026

Copy link
Copy Markdown

Webrevs

@vieiro

vieiro commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

See #3203 for a backport of JDK-8384815.

@gnu-andrew gnu-andrew left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change mostly looks good.

You mention the OCSP changes, yet I don't see anything adapting the test for the absence of this patch. The -Dcom.sun.security.ocsp.useget=false invocations are unnecessary in 11u and should be removed.

Compare CAInterop.java in 11u with 17u and you see:

--- ../jdk/test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java    2026-05-23 14:21:12.546949985 +0100
+++ test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java   2026-03-20 22:53:38.130634988 +0000
@@ -32,9 +32,6 @@
  * @run main/othervm/manual -Djava.security.debug=certpath,ocsp
  *  CAInterop actalisauthenticationrootca OCSP
  * @run main/othervm/manual -Djava.security.debug=certpath,ocsp
- *  -Dcom.sun.security.ocsp.useget=false
- *  CAInterop actalisauthenticationrootca OCSP
- * @run main/othervm/manual -Djava.security.debug=certpath,ocsp
  *  CAInterop actalisauthenticationrootca CRL
  */

etc.

It looks like this was also missed in backporting JDK-8341057 & JDK-8359170 too so it would be good to remove the additional lines there too.

@vieiro

vieiro commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Dropped Dcom.sun.security.ocsp.useget=false.

Test continue to pass:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java
                                                         1     1     0     0   
==============================
TEST SUCCESS

@vieiro vieiro requested a review from gnu-andrew May 28, 2026 18:27

@gnu-andrew gnu-andrew left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this on both the new changes and previous ones. This should be good to go.

@openjdk

openjdk Bot commented May 28, 2026

Copy link
Copy Markdown

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@vieiro

vieiro commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

/approval request Please consider approving this backport from JDK17 that adds two new Root CA certificates for WISeKey

@openjdk

openjdk Bot commented May 28, 2026

Copy link
Copy Markdown

@vieiro
8372351: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label May 28, 2026
@jerboaa

jerboaa commented May 29, 2026

Copy link
Copy Markdown
Contributor

/approve yes

@openjdk

openjdk Bot commented May 29, 2026

Copy link
Copy Markdown

@jerboaa
8372351: The approval request has been approved.

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels May 29, 2026
@vieiro

vieiro commented May 31, 2026

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk

openjdk Bot commented May 31, 2026

Copy link
Copy Markdown

Going to push as commit b8b274b.
Since your change was applied there have been 8 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label May 31, 2026
@openjdk openjdk Bot closed this May 31, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2026
@openjdk

openjdk Bot commented May 31, 2026

Copy link
Copy Markdown

@vieiro Pushed as commit b8b274b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants