Skip to content

8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation#3211

Closed
tabata-d wants to merge 2 commits into
openjdk:pr/3171from
tabata-d:JDK-8312585
Closed

8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation#3211
tabata-d wants to merge 2 commits into
openjdk:pr/3171from
tabata-d:JDK-8312585

Conversation

@tabata-d

@tabata-d tabata-d commented May 29, 2026

Copy link
Copy Markdown
Member

This fix addresses a usability and consistency issue in the HotSpot VM by renaming the command-line flag DisableTHPStackMitigation to THPStackMitigation. The original flag's name created a confusing double negation, where enabling the flag (+DisableTHPStackMitigation) actually disabled the underlying mitigation. The renaming resolves this by adopting a direct naming convention, where -XX:+THPStackMitigation enables the mitigation and -XX:-THPStackMitigation disables it, aligning with standard JDK flag practices.

We are backporting this fix from JDK 17 to JDK 11. This is considered an unclean backport due to minor Git diff differences from previous versions, such as JDK 17 using product where JDK 11 used diagnostic, and differing FLAG_SET_ERGO macro arguments.

Testing:
A full Hotspot jtreg run was executed on a Linux x86_64 machine and all are passed



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312585 needs maintainer approval

Integration blocker

 ⚠️ Dependency #3210 must be integrated first

Issue

  • JDK-8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3211/head:pull/3211
$ git checkout pull/3211

Update a local copy of the PR:
$ git checkout pull/3211
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3211

View PR using the GUI difftool:
$ git pr show -t 3211

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3211.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 29, 2026

Copy link
Copy Markdown

👋 Welcome back dtabata! A progress list of the required criteria for merging this PR into pr/3210 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 29, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title backport 226cdc696d933fbc174d07b0d9817246dbc0e06c 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation May 29, 2026
@openjdk

openjdk Bot commented May 29, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 29, 2026
@mlbridge

mlbridge Bot commented May 29, 2026

Copy link
Copy Markdown

Webrevs

@openjdk-notifier openjdk-notifier Bot changed the base branch from pr/3210 to pr/3171 June 8, 2026 01:53
@openjdk-notifier

Copy link
Copy Markdown

The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again.

@tabata-d

tabata-d commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

After the discussion in #3210, I have decided to close this PR.

@tabata-d tabata-d closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant