You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This fix addresses a usability and consistency issue in the HotSpot VM by renaming the command-line flag DisableTHPStackMitigation to THPStackMitigation. The original flag's name created a confusing double negation, where enabling the flag (+DisableTHPStackMitigation) actually disabled the underlying mitigation. The renaming resolves this by adopting a direct naming convention, where -XX:+THPStackMitigation enables the mitigation and -XX:-THPStackMitigation disables it, aligning with standard JDK flag practices.
We are backporting this fix from JDK 17 to JDK 11. This is considered an unclean backport due to minor Git diff differences from previous versions, such as JDK 17 using product where JDK 11 used diagnostic, and differing FLAG_SET_ERGO macro arguments.
Testing:
A full Hotspot jtreg run was executed on a Linux x86_64 machine and all are passed
👋 Welcome back dtabata! A progress list of the required criteria for merging this PR into pr/3210 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.
openjdkBot
changed the title
backport 226cdc696d933fbc174d07b0d9817246dbc0e06c
8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
May 29, 2026
The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportPort of a pull request already in a different code baserfrPull request is ready for review
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses a usability and consistency issue in the HotSpot VM by renaming the command-line flag
DisableTHPStackMitigationtoTHPStackMitigation. The original flag's name created a confusing double negation, where enabling the flag (+DisableTHPStackMitigation) actually disabled the underlying mitigation. The renaming resolves this by adopting a direct naming convention, where-XX:+THPStackMitigationenables the mitigation and-XX:-THPStackMitigationdisables it, aligning with standard JDK flag practices.We are backporting this fix from JDK 17 to JDK 11. This is considered an unclean backport due to minor Git diff differences from previous versions, such as JDK 17 using
productwhere JDK 11 useddiagnostic, and differingFLAG_SET_ERGOmacro arguments.Testing:
A full Hotspot jtreg run was executed on a Linux x86_64 machine and all are passed
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3211/head:pull/3211$ git checkout pull/3211Update a local copy of the PR:
$ git checkout pull/3211$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3211/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3211View PR using the GUI difftool:
$ git pr show -t 3211Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3211.diff
Using Webrev
Link to Webrev Comment