Skip to content

8311546: Certificate name constraints improperly validated with leading period#3221

Open
TheMangovnik wants to merge 3 commits into
openjdk:masterfrom
TheMangovnik:backport/JDK-8311546
Open

8311546: Certificate name constraints improperly validated with leading period#3221
TheMangovnik wants to merge 3 commits into
openjdk:masterfrom
TheMangovnik:backport/JDK-8311546

Conversation

@TheMangovnik

@TheMangovnik TheMangovnik commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Backport of JDK-8347424, JDK-8320372 and JDK-8311546.

Backporting this as it is marked as critical for the next CPU.

Tests

Tests were run on Fedora 44.

  • test/jdk/sun/security/x509/DNSName/LeadingPeriod.java - PASSING
    • This test is introduced in this backport. Fails before the backport changes and passes after the change.
  • test/jdk/sun/security - PASSING
    • Only sun/security/ssl/X509KeyManager/PreferredKey.java is failing, but that is unrelated to this backport.
  • Tier 1 - PASSING
  • gtest - PASSING


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320372 needs maintainer approval
  • JDK-8347424 needs maintainer approval
  • JDK-8311546 needs maintainer approval

Issues

  • JDK-8311546: Certificate name constraints improperly validated with leading period (Bug - P3)
  • JDK-8320372: test/jdk/sun/security/x509/DNSName/LeadingPeriod.java validity check failed (Bug - P2)
  • JDK-8347424: Fix and rewrite sun/security/x509/DNSName/LeadingPeriod.java test (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3221/head:pull/3221
$ git checkout pull/3221

Update a local copy of the PR:
$ git checkout pull/3221
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3221

View PR using the GUI difftool:
$ git pr show -t 3221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3221.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 4, 2026

Copy link
Copy Markdown

👋 Welcome back TheMangovnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 4, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title backport d2fb8c273488f0ff57e5f0aacb00d679d7ffa849 8311546: Certificate name constraints improperly validated with leading period Jun 4, 2026
@openjdk

openjdk Bot commented Jun 4, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 4, 2026
@mlbridge

mlbridge Bot commented Jun 4, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant