8311546: Certificate name constraints improperly validated with leading period#3221
Open
TheMangovnik wants to merge 3 commits into
Open
8311546: Certificate name constraints improperly validated with leading period#3221TheMangovnik wants to merge 3 commits into
TheMangovnik wants to merge 3 commits into
Conversation
|
👋 Welcome back TheMangovnik! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issues from the original commit. |
Webrevs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of JDK-8347424, JDK-8320372 and JDK-8311546.
Backporting this as it is marked as critical for the next CPU.
Tests
Tests were run on Fedora 44.
test/jdk/sun/security/x509/DNSName/LeadingPeriod.java- PASSINGtest/jdk/sun/security- PASSINGsun/security/ssl/X509KeyManager/PreferredKey.javais failing, but that is unrelated to this backport.Tier 1- PASSINGgtest- PASSINGProgress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3221/head:pull/3221$ git checkout pull/3221Update a local copy of the PR:
$ git checkout pull/3221$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3221/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3221View PR using the GUI difftool:
$ git pr show -t 3221Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3221.diff
Using Webrev
Link to Webrev Comment