Skip to content

8366342: Key generator and key pair generator tests skipping, but showing as passed#3224

Open
tkiriyama wants to merge 1 commit into
openjdk:masterfrom
tkiriyama:backport_8366342
Open

8366342: Key generator and key pair generator tests skipping, but showing as passed#3224
tkiriyama wants to merge 1 commit into
openjdk:masterfrom
tkiriyama:backport_8366342

Conversation

@tkiriyama

@tkiriyama tkiriyama commented Jun 8, 2026

Copy link
Copy Markdown
Member

Hi all,

I will backport JDK-8366342 from JDK 26 to JDK 11 to address an issue where, when specific PKCS#11 DES, ChaCha20 and DH capabilities were unavailable, tests would print a skipping message and return. This caused jtreg to misleadingly mark them as "Passed" because no explicit failure occurred. In other words, when PKCS#11 functionality was unavailable, the tests exited normally and were counted the same as successful tests, even though they did not actually verify any functionality.

This backport is equivalent to the fix applied in JDK 17.

There are additional, similar PKCS#11 test improvements in newer releases, but we plan to backport those to JDK 11 separately and in due course.

Thank you.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366342 needs maintainer approval

Issue

  • JDK-8366342: Key generator and key pair generator tests skipping, but showing as passed (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3224/head:pull/3224
$ git checkout pull/3224

Update a local copy of the PR:
$ git checkout pull/3224
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3224/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3224

View PR using the GUI difftool:
$ git pr show -t 3224

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3224.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 8, 2026

Copy link
Copy Markdown

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 8, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title backport 7690a45f77a2da47fa912fe7a2b2faa589f259f0 8366342: Key generator and key pair generator tests skipping, but showing as passed Jun 8, 2026
@openjdk

openjdk Bot commented Jun 8, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 8, 2026
@mlbridge

mlbridge Bot commented Jun 8, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant