8378180: Compiling OpenJDK with C23 C-Compiler gives warning: initialization discards ‘const’ qualifier from pointer target type#3231
Open
fthevenet wants to merge 1 commit into
Conversation
|
👋 Welcome back fthevenet! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an unclean backport of of commit 16971af1 from the openjdk/jdk17u-dev repository (itslef a backport of 76a44b3e from openjdk/jdk).
The aim for this backport is to address compiler warnings that arise when attempting to build with with more recent version of gcc (16.1+).
The patch does not appy cleanly; the following modifications were necessary:
src/jdk.jpackage/linux/native/applauncher/LinuxPackage.cas the file doesn't exists in jdk11src/java.base/unix/native/libnet/NetworkInterface.care not applicaple to jdk11 (*colonPis assigned a value at line 251, cannot be declaredconst)discarded-qualifierswarning insrc/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.cI have verified that with this patch, jdk11u-dev compiles without warning on Fedora 44 with gcc 16.1.1.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3231/head:pull/3231$ git checkout pull/3231Update a local copy of the PR:
$ git checkout pull/3231$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3231/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3231View PR using the GUI difftool:
$ git pr show -t 3231Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3231.diff
Using Webrev
Link to Webrev Comment