Skip to content

8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate#4475

Closed
GoeLin wants to merge 2 commits into
openjdk:masterfrom
GoeLin:goetz_backport_8384815
Closed

8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate#4475
GoeLin wants to merge 2 commits into
openjdk:masterfrom
GoeLin:goetz_backport_8384815

Conversation

@GoeLin

@GoeLin GoeLin commented May 21, 2026

Copy link
Copy Markdown
Member

Backport of the change in 21 to fix these test.

Not clean as
8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 was not backported to 17.

Applying the parts of 8308453 first matches clean, and 8384815 on top is clean as well.

Both tests pass.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8384815 needs maintainer approval

Issue

  • JDK-8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4475/head:pull/4475
$ git checkout pull/4475

Update a local copy of the PR:
$ git checkout pull/4475
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4475/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4475

View PR using the GUI difftool:
$ git pr show -t 4475

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4475.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 21, 2026

Copy link
Copy Markdown

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 21, 2026

Copy link
Copy Markdown

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate

Reviewed-by: syan, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 73c1634: 8290504: Close streams returned by ModuleReader::list

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title backport 1fcd11f41d1b50fb14e38fafefa492a31b166863 8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate May 21, 2026
@openjdk

openjdk Bot commented May 21, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 21, 2026
@mlbridge

mlbridge Bot commented May 21, 2026

Copy link
Copy Markdown

Webrevs

@sendaoYan sendaoYan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows-aarch64 / build (release) fails during jdk build. I think it's unrelated to this backport PR.

The proposed patch works for me.

@openjdk

openjdk Bot commented May 21, 2026

Copy link
Copy Markdown

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label May 21, 2026
@GoeLin

GoeLin commented May 21, 2026

Copy link
Copy Markdown
Member Author

GHA failure: fixpath.sh: line 412: 1910 Segmentation fault
build issue. Yes, I also think it's unrelated to this test fix.

@GoeLin

GoeLin commented May 21, 2026

Copy link
Copy Markdown
Member Author

/integrate

@openjdk

openjdk Bot commented May 21, 2026

Copy link
Copy Markdown

@GoeLin This pull request has not yet been marked as ready for integration.

@GoeLin

GoeLin commented May 21, 2026

Copy link
Copy Markdown
Member Author

/integrate

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels May 21, 2026
@openjdk

openjdk Bot commented May 21, 2026

Copy link
Copy Markdown

Going to push as commit 1e71490.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 73c1634: 8290504: Close streams returned by ModuleReader::list

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label May 21, 2026
@openjdk openjdk Bot closed this May 21, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 21, 2026
@openjdk

openjdk Bot commented May 21, 2026

Copy link
Copy Markdown

@GoeLin Pushed as commit 1e71490.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8384815 branch May 21, 2026 12:18
@GoeLin GoeLin restored the goetz_backport_8384815 branch May 21, 2026 12:19
@sendaoYan

Copy link
Copy Markdown
Member

Hi @GoeLin , I have created a backport PR to backport this to jdk11u if you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants