8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate#4475
8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate#4475GoeLin wants to merge 2 commits into
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
sendaoYan
left a comment
There was a problem hiding this comment.
windows-aarch64 / build (release) fails during jdk build. I think it's unrelated to this backport PR.
The proposed patch works for me.
|
|
|
GHA failure: fixpath.sh: line 412: 1910 Segmentation fault |
|
/integrate |
|
@GoeLin This pull request has not yet been marked as ready for integration. |
|
/integrate |
|
Hi @GoeLin , I have created a backport PR to backport this to jdk11u if you don't mind. |
Backport of the change in 21 to fix these test.
Not clean as
8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 was not backported to 17.
Applying the parts of 8308453 first matches clean, and 8384815 on top is clean as well.
Both tests pass.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4475/head:pull/4475$ git checkout pull/4475Update a local copy of the PR:
$ git checkout pull/4475$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4475/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4475View PR using the GUI difftool:
$ git pr show -t 4475Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4475.diff
Using Webrev
Link to Webrev Comment