Skip to content

8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate#200

Open
sendaoYan wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-sendaoYan-1fcd11f4-master
Open

8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate#200
sendaoYan wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-sendaoYan-1fcd11f4-master

Conversation

@sendaoYan

@sendaoYan sendaoYan commented May 19, 2026

Copy link
Copy Markdown
Member

Hi all,

This pull request contains a backport of commit 1fcd11f4 from the openjdk/jdk repository.

The commit being backported was authored by Rajan Halade on 19 May 2026 and was reviewed by Artur Barashev, Sean Mullan, SendaoYan and Mikhail Yankelevich.

Thanks!



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8384815 needs maintainer approval

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate (Bug - P2 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk26u.git pull/200/head:pull/200
$ git checkout pull/200

Update a local copy of the PR:
$ git checkout pull/200
$ git pull https://git.openjdk.org/jdk26u.git pull/200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 200

View PR using the GUI difftool:
$ git pr show -t 200

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk26u/pull/200.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 19, 2026

Copy link
Copy Markdown

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 19, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 1fcd11f41d1b50fb14e38fafefa492a31b166863 8384815: SelectOneKeyOutOfMany and PreferredKey fail after expired test certificate May 19, 2026
@openjdk

openjdk Bot commented May 19, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 19, 2026
@openjdk

openjdk Bot commented May 19, 2026

Copy link
Copy Markdown

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 19, 2026
@mlbridge

mlbridge Bot commented May 19, 2026

Copy link
Copy Markdown

Webrevs

@sendaoYan

sendaoYan commented May 20, 2026

Copy link
Copy Markdown
Member Author

/approval request Clean backport to make test generate certificates during test run which avoid the fix certificate expired cause test fails. Change has been verified locally by run the releated on linux-x64. Test-fix only, no risk.

@openjdk

openjdk Bot commented May 20, 2026

Copy link
Copy Markdown

@sendaoYan
8384815: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label May 20, 2026
@bridgekeeper bridgekeeper Bot added the oca Needs verification of OCA signatory status label May 28, 2026
@openjdk openjdk Bot removed the rfr Pull request is ready for review label May 28, 2026
@bridgekeeper

bridgekeeper Bot commented Jun 26, 2026

Copy link
Copy Markdown

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required oca Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

1 participant