Skip to content

8366441: AArch64: Support WFET in OnSpinWait#209

Open
ruben-arm wants to merge 1 commit into
openjdk:masterfrom
ruben-arm:pr-backport-wfet-to-jdk26
Open

8366441: AArch64: Support WFET in OnSpinWait#209
ruben-arm wants to merge 1 commit into
openjdk:masterfrom
ruben-arm:pr-backport-wfet-to-jdk26

Conversation

@ruben-arm

@ruben-arm ruben-arm commented May 27, 2026

Copy link
Copy Markdown

Hi,

This is a backport of 8366441: AArch64: Support WFET in OnSpinWait (openjdk/jdk#27030)

There is a difference from the original commit - in the test/hotspot/gtest/aarch64/asmtest.out.h file generated using aarch64-asmtest.py.

Testing:

  • fastdebug test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWaitAArch64.java on Arm Cortex-X925 and Arm Neoverse V2 cores
  • release and fastdebug hotspot tier1, tier2, tier3 - on AArch64, x86_64

Thank you,
Ruben



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366441 needs maintainer approval

Issue

  • JDK-8366441: AArch64: Support WFET in OnSpinWait (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk26u.git pull/209/head:pull/209
$ git checkout pull/209

Update a local copy of the PR:
$ git checkout pull/209
$ git pull https://git.openjdk.org/jdk26u.git pull/209/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 209

View PR using the GUI difftool:
$ git pr show -t 209

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk26u/pull/209.diff

Using Webrev

Link to Webrev Comment

8366441: AArch64: Support WFET in OnSpinWait

Co-authored-by: Stuart Monteith <smonteith@openjdk.org>
Co-authored-by: Andrew Haley <aph@openjdk.org>
Reviewed-by: aph, eastigeevich
@bridgekeeper

bridgekeeper Bot commented May 27, 2026

Copy link
Copy Markdown

👋 Welcome back ruben-arm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 27, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport dfe438d0570ada60de9d8dd7cdf97d229d91fc48 8366441: AArch64: Support WFET in OnSpinWait May 27, 2026
@openjdk

openjdk Bot commented May 27, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels May 27, 2026
@mlbridge

mlbridge Bot commented May 27, 2026

Copy link
Copy Markdown

Webrevs

@ruben-arm

Copy link
Copy Markdown
Author

/approval request The motivation behind backporting is performance improvement related to Thread.onSpinWait - specific data on improvements is available at openjdk/jdk#27030 (in comment added on 5 February).
This doesn't change the behaviour unless a respective command line option is supplied, therefore is expected to be a low risk.

@openjdk

openjdk Bot commented May 27, 2026

Copy link
Copy Markdown

@ruben-arm
8366441: The approval request has been created successfully.

@bridgekeeper

bridgekeeper Bot commented Jun 25, 2026

Copy link
Copy Markdown

@ruben-arm This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ruben-arm

Copy link
Copy Markdown
Author

/keepalive

@openjdk

openjdk Bot commented Jun 25, 2026

Copy link
Copy Markdown

@ruben-arm The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants