8221710: [TESTBUG] more configurable parameters for docker testing#805
8221710: [TESTBUG] more configurable parameters for docker testing#805yaqsun wants to merge 1 commit into
Conversation
|
👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue and summary from the original commit. |
|
Seems simple enough. Is there a greater context of why this needs to be backported to JDK 8? |
It's already been backported to all versions above 8. The reason we need this in JDK 8 is that several test cases under jdk/internal/platform/docker/* are failing when run in a Docker-launched environment, and they depend on this change. |
Only SkippedException is backported; the other changes have already been backported, and test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java has been iteratively updated.
Through testing, this backport passes the test cases below when the Docker status is 'start'.
jdk/internal/platform/docker/TestDockerBasic.java jdk/internal/platform/docker/TestDockerCpuMetrics.java jdk/internal/platform/docker/TestDockerMemoryMetrics.java jdk/internal/platform/docker/TestGetFreeSwapSpaceSize.java jdk/internal/platform/docker/TestSystemMetrics.java jdk/internal/platform/docker/TestUseContainerSupport.javaProgress
Error
- [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/805/head:pull/805$ git checkout pull/805Update a local copy of the PR:
$ git checkout pull/805$ git pull https://git.openjdk.org/jdk8u-dev.git pull/805/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 805View PR using the GUI difftool:
$ git pr show -t 805Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/805.diff