8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates#813
8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates#813jerboaa wants to merge 1 commit into
Conversation
8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates Remove CA_DSA_1024 and EE_DSA_1024 NamedGroupsWithCipherSuite.java is not in 8u. See: 8243549: sun/security/ssl/CipherSuite/NamedGroupsWithCipherSuite.java failed with Unsupported signature algorithm: DSA 8224650: Add tests to support X25519 and X448 in TLS Port SocketExceptionForSocketIssues.java test from 11u
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
GHA failures are https://bugs.openjdk.org/browse/JDK-8385585 and https://bugs.openjdk.org/browse/JDK-8385584 |
|
@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Please review this test-only change for 8u in preparation for JDK-8340321 and JDK-8349583 backports for a crypto roadmap update. The patch is not entirely clean. The most significant differences to JDK 11u are:
RestrictSignatureScheme.javaare omitted since the bug which introduces this test is not yet in 8u (JDK-8226374). This backport isn't strictly needed and since this backport required already quite a few - mostly - test-only backports as deps I've omitted it.SSLContextTemplate.javahas been done manually because: a) context changes are large enough so that the patch doesn't apply cleanly b) even if it did, 11u has an extra test,NamedGroupsWithCipherSuite.javawhich usesSSLSocketTemplate.Cert.CA_DSA_1024, andSSLSocketTemplate.Cert.EE_DSA_1024and are only used in that test. The test has been introduced with8224650: Add tests to support X25519 and X448 in TLSand then modified inJDK-8243549both of which aren't in 8u. Therefore, I've not brought those certs intoSSLSocketTemplate. They weren't there before anyway.SSLEngineBadBufferArrayAccess.javahas a different ssl library path in 8u.SSLSocketTemplate.javahas the same issue asSSLContextTemplate.javawithCA_DSA_1024andEE_DSA_1024not being present in 8u.SocketExceptionForSocketIssues.javahas differences to 11u, because of differences in theJDK-8259662backport. See 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl #808 for details.SigAlgosExtTestWithTLS12.javawhich needed modifications to the test inJDK-8263188(8263188: JSSE should fail fast if there isn't supported signature algorithm #811) so that the test compiles on 8u.Otherwise, the usual path changes apply.
Testing
jdk/test/javax/net/ssl,jdk/test/sun/net/www/protocol/https/andjdk/test/sun/security/ssl/tests with the following result:Test results: passed: 267; failed: 2; error: 1=> same failures as for master. Same number of tests passing as in 8263188: JSSE should fail fast if there isn't supported signature algorithm #811.Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/813/head:pull/813$ git checkout pull/813Update a local copy of the PR:
$ git checkout pull/813$ git pull https://git.openjdk.org/jdk8u-dev.git pull/813/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 813View PR using the GUI difftool:
$ git pr show -t 813Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/813.diff
Using Webrev
Link to Webrev Comment