Skip to content

Use bundled zlib on MacOS#814

Draft
gnu-andrew wants to merge 2 commits into
openjdk:masterfrom
gnu-andrew:zlib-bundled-test
Draft

Use bundled zlib on MacOS#814
gnu-andrew wants to merge 2 commits into
openjdk:masterfrom
gnu-andrew:zlib-bundled-test

Conversation

@gnu-andrew

@gnu-andrew gnu-andrew commented May 29, 2026

Copy link
Copy Markdown
Member

Patch on top of #812 to check bundled zlib on MacOS



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/814/head:pull/814
$ git checkout pull/814

Update a local copy of the PR:
$ git checkout pull/814
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/814/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 814

View PR using the GUI difftool:
$ git pr show -t 814

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/814.diff

@bridgekeeper

bridgekeeper Bot commented May 29, 2026

Copy link
Copy Markdown

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into pr/812 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 29, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk-notifier openjdk-notifier Bot changed the base branch from pr/812 to master June 3, 2026 09:37
@openjdk-notifier

Copy link
Copy Markdown

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout zlib-bundled-test
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants