Skip to content

8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate#824

Open
vieiro wants to merge 1 commit into
openjdk:pr/820from
vieiro:backports/JDK-8306014
Open

8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate#824
vieiro wants to merge 1 commit into
openjdk:pr/820from
vieiro:backports/JDK-8306014

Conversation

@vieiro

@vieiro vieiro commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Backport of JDK-8306014 from JDK11 on top of #820 (for JDK-8306015 ), in order to continue updating SSL testing for JDK8 (this is a test-only change).

Test results are the same as in #820:

TEST RESULT: Passed. Execution successful
--------------------------------------------------
Test results: passed: 267; failed: 2; error: 1
  • Failed:
    • javax/net/ssl/compatibility/Compatibility.java: This test is used to check the interop compatibility on JSSE among different JDK releases.
    • sun/security/ssl/X509KeyManager/PreferredKey.java: X509KeyManager implementation for NewSunX509 doesn't return most preferable key
  • Error:
    • sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java: Test that creating and closing SSL Sockets without bind/connect will not leave leaking socket file descriptors


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8306014 needs maintainer approval

Integration blocker

 ⚠️ Dependency #820 must be integrated first

Issue

  • JDK-8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/824/head:pull/824
$ git checkout pull/824

Update a local copy of the PR:
$ git checkout pull/824
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/824/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 824

View PR using the GUI difftool:
$ git pr show -t 824

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/824.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 3, 2026

Copy link
Copy Markdown

👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into pr/820 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 3, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 68c6e5ca45b80ed9549d8589779bc847a49277e2 8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate Jun 3, 2026
@openjdk

openjdk Bot commented Jun 3, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 3, 2026
@mlbridge

mlbridge Bot commented Jun 3, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant