8239798: SSLSocket closes socket both socket endpoints on a SocketTimeoutException

[jerboaa]

Almost clean backport, but for the differences in the TLS 1.3 backport which omitted the DTLS part. Thus, ProtocolVersion.isNegotiable() has a different signature (missing the second last boolean of isDTLS). Otherwise a clean backport. This is in preparation for #808.

Testing:

• jdk/test/javax/net/ssl, jdk/test/sun/net/www/protocol/https/ and jdk/test/sun/security/ssl/ with the following results: Test results: passed: 264; failed: 2; error: 1. Note the total number of 264 over current master, since this patch also enables ClientTimeout.java which passes.
• GHA

Thoughts?

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8239798 needs maintainer approval

Issue

• JDK-8239798: SSLSocket closes socket both socket endpoints on a SocketTimeoutException (Bug - P2 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/825/head:pull/825
$ git checkout pull/825

Update a local copy of the PR:
$ git checkout pull/825
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/825/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 825

View PR using the GUI difftool:
$ git pr show -t 825

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/825.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8239798: SSLSocket closes socket both socket endpoints on a SocketTimeoutException

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 11d368c: 8372351: Add 2 WISeKey roots
• bb816ae: 8383354: Update LCMS to 2.19.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (c67b0921)

[jerboaa]

GHA failures are the same jdk/security_infra failures we see elsewhere.

[gnu-andrew]

I'm surprised this is so clean but I guess that is due to the import of the new TLS implementation and this patch following not long after.

Backport & testing look good to me.

[openjdk]

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[jerboaa]

/approval request Please approve this backport to the JDK 8u TLS stack which almost applies cleanly modulo path changes. The differences is in no DTLS in 8u vs. 11u. The motivation for backporting this is to get a crypto roadmap update into 8u. Patch has been reviewed by Andrew Hughes. TLS tests pass. Risk is medium, but it's been in Oracle 8u for a while and we've not seen issues in 11u as well.

[openjdk]

@jerboaa
8239798: The approval request has been created successfully.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8239798: The approval request has been approved.

[jerboaa]

/integrate

[openjdk]

Going to push as commit 40be762.
Since your change was applied there have been 2 commits pushed to the master branch:

• 11d368c: 8372351: Add 2 WISeKey roots
• bb816ae: 8383354: Update LCMS to 2.19.1

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit 40be762.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.