Skip to content

8252250: isnanf is obsolete#831

Open
elifaslan1 wants to merge 1 commit into
openjdk:masterfrom
elifaslan1:JDK-8252250
Open

8252250: isnanf is obsolete#831
elifaslan1 wants to merge 1 commit into
openjdk:masterfrom
elifaslan1:JDK-8252250

Conversation

@elifaslan1

@elifaslan1 elifaslan1 commented Jun 10, 2026

Copy link
Copy Markdown

Clean backport of JDK-8252250 insnanf is obsolute. Low risk.

GHA tested



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8252250 needs maintainer approval

Issue

  • JDK-8252250: isnanf is obsolete (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/831/head:pull/831
$ git checkout pull/831

Update a local copy of the PR:
$ git checkout pull/831
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/831/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 831

View PR using the GUI difftool:
$ git pr show -t 831

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/831.diff

Using Webrev

Link to Webrev Comment

Reviewed-by: vkempik
Backport-of: b957d802e6982be56d3a344668d8fd230f20d0df
@bridgekeeper

bridgekeeper Bot commented Jun 10, 2026

Copy link
Copy Markdown

👋 Welcome back easlan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 10, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@elifaslan1 elifaslan1 changed the title Backport of 49f91052b8930b23ceff7399151e4225762bd13d JDK-8252250 : Backport of 49f91052b8930b23ceff7399151e4225762bd13d Jun 10, 2026
@elifaslan1 elifaslan1 changed the title JDK-8252250 : Backport of 49f91052b8930b23ceff7399151e4225762bd13d 8252250: isnanf is obsolete Jun 10, 2026
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 10, 2026
@mlbridge

mlbridge Bot commented Jun 10, 2026

Copy link
Copy Markdown

Webrevs

@elifaslan1 elifaslan1 changed the title 8252250: isnanf is obsolete Backport of 49f91052b8930b23ceff7399151e4225762bd13d Jun 12, 2026
@openjdk openjdk Bot removed the rfr Pull request is ready for review label Jun 12, 2026
@elifaslan1 elifaslan1 changed the title Backport of 49f91052b8930b23ceff7399151e4225762bd13d Backport 49f91052b8930b23ceff7399151e4225762bd13d Jun 12, 2026
@openjdk openjdk Bot changed the title Backport 49f91052b8930b23ceff7399151e4225762bd13d 8252250: isnanf is obsolete Jun 12, 2026
@openjdk

openjdk Bot commented Jun 12, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 12, 2026

@phohensee phohensee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean other than file location, so lgtm.

@openjdk

openjdk Bot commented Jun 12, 2026

Copy link
Copy Markdown

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@elifaslan1

Copy link
Copy Markdown
Author

/approval request , Clean backport of JDK-8252250 insnanf is obsolute. Test failures are not related to the change.

@openjdk

openjdk Bot commented Jun 15, 2026

Copy link
Copy Markdown

@elifaslan1
8252250: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants