8387374: [lworld] Address test issues in test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java#2590
Open
jaikiran wants to merge 3 commits into
Open
8387374: [lworld] Address test issues in test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java#2590jaikiran wants to merge 3 commits into
jaikiran wants to merge 3 commits into
Conversation
…e/valueObjects/ValueSerializationTest.java
|
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can I please get a review of this test-only change which addresses the issues in its parameterized tests, as noted here https://github.com/openjdk/jdk/pull/31123/changes#r3486082890?
While at it, I also did a general clean up of the test and added comments to the test methods and the classes used in that test to clarify what's being covered by this test.
The test continues to pass after this change and the test methods get run more number of times (as expected) due to fixing the parameters being generated for the parameterized tests.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2590/head:pull/2590$ git checkout pull/2590Update a local copy of the PR:
$ git checkout pull/2590$ git pull https://git.openjdk.org/valhalla.git pull/2590/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2590View PR using the GUI difftool:
$ git pr show -t 2590Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2590.diff
Using Webrev
Link to Webrev Comment