Skip to content

8387374: [lworld] Address test issues in test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java#2590

Open
jaikiran wants to merge 3 commits into
openjdk:lworldfrom
jaikiran:8387374
Open

8387374: [lworld] Address test issues in test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java#2590
jaikiran wants to merge 3 commits into
openjdk:lworldfrom
jaikiran:8387374

Conversation

@jaikiran

@jaikiran jaikiran commented Jun 27, 2026

Copy link
Copy Markdown
Member

Can I please get a review of this test-only change which addresses the issues in its parameterized tests, as noted here https://github.com/openjdk/jdk/pull/31123/changes#r3486082890?

While at it, I also did a general clean up of the test and added comments to the test methods and the classes used in that test to clarify what's being covered by this test.

The test continues to pass after this change and the test methods get run more number of times (as expected) due to fixing the parameters being generated for the parameterized tests.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8387374: [lworld] Address test issues in test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2590/head:pull/2590
$ git checkout pull/2590

Update a local copy of the PR:
$ git checkout pull/2590
$ git pull https://git.openjdk.org/valhalla.git pull/2590/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2590

View PR using the GUI difftool:
$ git pr show -t 2590

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2590.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 27, 2026

Copy link
Copy Markdown

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 27, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 27, 2026
@mlbridge

mlbridge Bot commented Jun 27, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant