articles filter select and clear all buttons#5184
Open
StephDriver wants to merge 4 commits intomasterfrom
Open
articles filter select and clear all buttons#5184StephDriver wants to merge 4 commits intomasterfrom
StephDriver wants to merge 4 commits intomasterfrom
Conversation
StephDriver
force-pushed
the
b-2097-filter-toggle-all
branch
from
644c5cd to
864adef
Compare
Member
Author
|
feature created and working on material and clean. In progress debugging for OLH where it doesn't work. So far have found the js is intialising, have inserted console.log statements to track why button presses don't seem to do anything. Could be an incompatibility with Foundation - wondering if there is a native Foundation way to add this functionality. Might be worth looking at what other forms might use this select/clear all as well. |
Member
Author
|
the problem was that OLH theme initialise the filter twice, once for mobile once for desktop, whereas teh other themes initalise it once. I modified the OLH article_list template to incldue a context for the filter (desktop, mobile) and used that to differentiate. |
StephDriver
force-pushed
the
b-2097-filter-toggle-all
branch
from
864adef to
b4f57a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2097