Open
Conversation
slushie
force-pushed
the
issue-87
branch
2 times, most recently
from
ab08f1b to
b4cef23
Compare
hinshun
reviewed
Apr 21, 2020
| } | ||
| `, | ||
| ErrWrongArgType{ | ||
| Pos: makePos(2, 8), |
Contributor
There was a problem hiding this comment.
Do you think we should abstract the testing away from these node positions? Or do you think they belong here?
| r = recover() | ||
| }() | ||
| err = Check(mod) | ||
| }() |
Contributor
There was a problem hiding this comment.
We should probably return errors.WithStack instead of panicking in Check.
4 tasks
Contributor
|
@slushie Needs a rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #87
Some failing tests due to changes required in the
checkerpackage, provided in another PR.