Conversation
252ad57 to
13cd92a
Compare
slushie
reviewed
Dec 5, 2020
| return map[string]interface{}{ | ||
| // dockerDomain returns the domain/host information for the provided | ||
| // docker image | ||
| "dockerDomain": func(in string) string { |
Contributor
There was a problem hiding this comment.
Does it have to be dockerFoo? Could this be imageRefDomain or something a bit more OCI-friendly? 😉
Contributor
There was a problem hiding this comment.
Was chatting on slack, but I was suggesting since we had interpolation support in heredocs, I prefer if we use regular string functions rather than template functions.
Along with the array support proposal, you could do something like:
[]string dockerRegistries() {
"titusregistry.us-east-1.netflix.net"
"titusregistry.us-west-2.netflix.net"
}
[]string pushTargets(string ref) {
for (string registry in dockerRegistries) {
"${registry}/${dockerPath(ref)}:${dockerTag(ref)}
}
}
fs titusPush(string ref) {
for (string target in pushTargets(ref)) {
dockerPush target
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the sprig template funcs for general usage
Also I have added several docker image parsing template funcs which I have needed for various docker image publishing routines.