add UI support for repo field in search results#304
Conversation
|
A couple days before your change, #302 was merged which handles the But the bigger issue is that we removed Flask entirely from this repository recently, so your work was on the old UI, oops! We want this change on the new React-based front-end, which currently looks like this:
I'm thinking we want something like the version number tag (in the above screenshot, it's "0.2.0-1"), perhaps in another color? For sources that come from the IBM Validated software list. |
ee3cf62 to
8c2cc9c
Compare
|
Hi @pleia2, @vmuralictr thanks for the feedback! I've updated the PR to work with the new React/Node.js stack instead of the old Flask-based UI. Removed the old Flask-based changes (src/classes/package_search.py, src/static/js/views/home.html) since Flask has been removed from the repo |
|
if there any issue then do let me know sorry for the delay |
| > | ||
| Validated | ||
| </a> | ||
| )} |
There was a problem hiding this comment.
The repo isn't a web address, so it's not something we'll be linking to.
Using the https://github.com/linux-on-ibm-z/PDS/blob/master/distro_data/SUSE_Package_Hub_SLES_16_SP0.json file as an example, the json looks like this:
{"packageName":"389-ds", "version":"3.0.6~git86.dce421a0d-160000.2.2", "repo":"FTP3 Product-SLES16.0 Pool scc repository"},
So "FTP3 Product-SLES16.0 Pool scc repository" is what would be displayed for this tag.
We also want to make showing this field optional, since it's rather niche and most folks searching won't need to see it.
pleia2
left a comment
There was a problem hiding this comment.
We'll also need the DCO sign-off on the commits 😄
- Show repo as plain text (not a link) since it is not a URL - Add optional Show Repository checkbox to toggle visibility Signed-off-by: Mansi2007275 <yadavmansi0111207@gmail.com>
|
Hi @pleia2, Thanks for the feedback! I've made the following changes: Removed the link — changed the repo tag from a clickable link to a plain , since the repo field isn't a URL. It now displays the actual repo text (e.g. "FTP3 Product-SLES16.0 Pool scc repository") instead of the hardcoded "Validated" label. Let me know if any further changes are needed! |

Summary
Closes #265
Adds optional UI support for the
repofield now presentin PDS data sources.
Changes Made
bin/database_build.pyrepocolumn to MySQL table schema increateTable()jsontosql()to handle all INSERT casessrc/classes/package_search.pyrepoto both SELECT queries insearchSQLPackages()src/static/js/views/home.htmlexists, shows
—when absent