Skip to content

f-string guidelines using Flynt#1406

Merged
PGijsbers merged 11 commits into
openml:developfrom
SubhadityaMukherjee:flynt
Jun 18, 2025
Merged

f-string guidelines using Flynt#1406
PGijsbers merged 11 commits into
openml:developfrom
SubhadityaMukherjee:flynt

Conversation

@SubhadityaMukherjee
Copy link
Copy Markdown
Contributor

Reference Issue

Fixes #1295

What does this PR implement/fix? Explain your changes.

As Eddie and Pieter mentioned in #1295, this runs Flynt (a compliancy checker for f-strings) on the codebase, and adds a guideline for future contributors to ensure compliance.

How should this PR be tested?

This does not add any new functionality. Just converts non f-strings to f-strings, so hopefully all the current tests should just work.

Any other comments?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 17, 2025

Codecov Report

❌ Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.09%. Comparing base (483f467) to head (2cb58a0).

Files with missing lines Patch % Lines
openml/setups/setup.py 0.00% 3 Missing ⚠️
openml/evaluations/evaluation.py 0.00% 1 Missing ⚠️
openml/extensions/sklearn/extension.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1406      +/-   ##
===========================================
+ Coverage    84.05%   84.09%   +0.04%     
===========================================
  Files           38       38              
  Lines         5230     5231       +1     
===========================================
+ Hits          4396     4399       +3     
+ Misses         834      832       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the old text also became obsolete.

Comment thread CONTRIBUTING.md Outdated
SubhadityaMukherjee and others added 2 commits June 17, 2025 11:29
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Comment thread openml/datasets/functions.py Outdated
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Comment thread openml/setups/functions.py Outdated
Comment thread tests/test_extensions/test_sklearn_extension/test_sklearn_extension.py Outdated
Copy link
Copy Markdown
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✏️

@PGijsbers PGijsbers merged commit d88f885 into openml:develop Jun 18, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Contributing] Mentions string.format, are f-strings allowed?

3 participants