Remove scikit-learn extension as submodule, publish independently instead#1424
Merged
Conversation
It will now be hosted in a separate repository
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1424 +/- ##
===========================================
- Coverage 53.71% 52.75% -0.97%
===========================================
Files 38 36 -2
Lines 5229 4343 -886
===========================================
- Hits 2809 2291 -518
+ Misses 2420 2052 -368 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LennartPurucker
approved these changes
Jun 19, 2025
Contributor
LennartPurucker
left a comment
There was a problem hiding this comment.
LGTM, one small question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
openml-sklearnin order to userun_model_on_taskand other extension functions withscikit-learnobjects.Details
The scikit-learn extension repository is here: https://github.com/openml/openml-sklearn
It is now used as a dependency for tests only, which means that scikit-learn will no longer be a dependency of
openml-pythonitself.Next steps are to remove dependency on the scikit-learn extension as much as possible for tests.