Default to not checking for duplicates#1431
Merged
Merged
Conversation
This makes it so by default people can use this feature without authenticating with OpenML.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1431 +/- ##
===========================================
- Coverage 52.75% 52.69% -0.06%
===========================================
Files 36 36
Lines 4343 4346 +3
===========================================
- Hits 2291 2290 -1
- Misses 2052 2056 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PGijsbers
commented
Jun 20, 2025
| with tmp_file.open("w") as config_file: | ||
| config_file.write(config_file_content) | ||
| read_config = openml.config._parse_config(tmp_path) | ||
| read_config = openml.config._parse_config(tmp_file) |
Collaborator
Author
There was a problem hiding this comment.
This was passed a directory... which lead to a silent error and an empty config, which went unnoticed because the values below happened to coincide with the old defaults :D
PGijsbers
commented
Jun 20, 2025
PGijsbers
commented
Jun 20, 2025
PGijsbers
commented
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
avoid_duplicate_runsparameter ofopenml.runs.run_model_on_taskandopenml.runs.run_flow_on_tasknow defaults toFalseinstead ofTrueand this default is now configurable from your configuration file.Details
The main reason for doing this is so that it doesn't require an API key by default. This API key was necessary to check for duplicate runs, because that uses an authenticated flow endpoint (
flow/exists).