Skip to content

Modernize _delete_entity with Literal typing and f-string formatting#1513

Closed
axif0 wants to merge 1 commit into
openml:mainfrom
axif0:todo_fix
Closed

Modernize _delete_entity with Literal typing and f-string formatting#1513
axif0 wants to merge 1 commit into
openml:mainfrom
axif0:todo_fix

Conversation

@axif0
Copy link
Copy Markdown

@axif0 axif0 commented Nov 25, 2025

Modernizes _to_dict by replacing temporary variables with walrus operator assignments and removing outdated Python 3.7 comments.

  • Replaced content = getattr(...) + if with walrus operator for brevity.
  • Removed legacy TODO notes about dropping Python 3.7.
  • Improved readability and reduced repetition in both simple and complex property handling.

Copy link
Copy Markdown
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We are currently doing server maintenance so CI/CD might be a bit flaky. Things should stabilize by next week, but we might not be able to merge it before then.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.99%. Comparing base (4b1bdf4) to head (99e3bad).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1513       +/-   ##
============================================
- Coverage    79.90%   55.99%   -23.92%     
============================================
  Files           36       36               
  Lines         4349     4347        -2     
============================================
- Hits          3475     2434     -1041     
- Misses         874     1913     +1039     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axif0 axif0 closed this by deleting the head repository May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants