reduce invalidation frequency

[maerki]

No description provided.

[Copilot]

Pull Request Overview

This PR introduces a mechanism to skip minor GPS position updates to reduce invalidation frequency.

• Extracted mapCoordinateSystem into a local variable for reuse
• Added a threshold check to early-return on negligible position changes
• Refactored repeated getMapConfig().mapCoordinateSystem accesses

Comments suppressed due to low confidence (2)

shared/src/gps/GpsLayer.cpp:136

• [nitpick] The variable name threshold is generic. Consider renaming to something more descriptive, like positionChangeThreshold.

    auto threshold = mapCoordinateSystem.unitToScreenMeterFactor * 10;

shared/src/gps/GpsLayer.cpp:120

• The indentation on this continued line is inconsistent with the project style. Align it with the opening parenthesis for clarity.

                mapCoordinateSystem.identifier, position);

[Copilot]

The hard-coded multiplier 10 is a magic number. Consider defining a named constant (e.g., kMinUpdateDistanceScreenMeters) or documenting why 10 is chosen.

Suggested change

	auto threshold = mapCoordinateSystem.unitToScreenMeterFactor * 10;
	auto threshold = mapCoordinateSystem.unitToScreenMeterFactor * kMinUpdateDistanceScreenMeters;

[maurhofer-ubique]

On Android, this is usually a configuration value in the LocationProvider itself (so the client decides whats best). Shouldn't we make it configurable at least?

[Copilot]

Using abs() on floating-point differences may invoke the integer overload. Use std::abs (from ) or std::fabs to ensure correct floating-point behavior.

[maurhofer-ubique]

On Android, this is usually a configuration value in the LocationProvider itself (so the client decides whats best). Shouldn't we make it configurable at least?