relay: fix shutdown hang when sessions hold lingering server refs#359
Merged
Conversation
afrind
requested review from
Oxyd,
TimEvens,
akash-a-n,
gmarzot,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
main() now owns the IOThreadPoolExecutor via unique_ptr (servers hold a raw pointer) and explicitly stops + clears servers before joining the IO pool. Previously, lingering shared_ptr<MoQServerBase> refs from in-flight sessions or coroutines could delay ~MoqxRelayServer past the executor's destruction, leaving QuicServer::shutdown to post to dead worker EVBs and hang shutdown until the 10s watchdog fired. MoqxRelayServer::stop() and MoqxPicoRelayServer::stop() are made idempotent using context_ as the sentinel, so ~MoqxRelayServer is a no-op once main has already stopped the server.
afrind
force-pushed
the
relay/io-executor-owned-by-main
branch
from
01d7417 to
fef5413
Compare
afrind
changed the title
gmarzot
approved these changes
May 31, 2026
Contributor
gmarzot
left a comment
gmarzot
left a comment
There was a problem hiding this comment.
@gmarzot reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on akash-a-n, michalhosna, mondain, Oxyd, peterchave, suhasHere, and TimEvens).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main() now owns the IOThreadPoolExecutor via unique_ptr (servers hold a
raw pointer) and explicitly stops + clears servers before joining the IO
pool. Previously, lingering shared_ptr refs from in-flight
sessions or coroutines could delay ~MoqxRelayServer past the executor's
destruction, leaving QuicServer::shutdown to post to dead worker EVBs
and hang shutdown until the 10s watchdog fired.
MoqxRelayServer::stop() and MoqxPicoRelayServer::stop() are made
idempotent using context_ as the sentinel, so ~MoqxRelayServer is a
no-op once main has already stopped the server.
This change is