Skip to content

test: parameterize relay tests for SingleThread and MultiThread modes#360

Merged
afrind merged 1 commit into
mainfrom
pr360
Jun 1, 2026
Merged

test: parameterize relay tests for SingleThread and MultiThread modes#360
afrind merged 1 commit into
mainfrom
pr360

Conversation

@afrind
Copy link
Copy Markdown
Contributor

@afrind afrind commented Jun 1, 2026

Converts all MoQRelayTest TEST_F cases to TEST_P and instantiates them
under AllModes/MoQRelayTest with named variants (SingleThread, MultiThread).

MoqxTrackFilterTest overrides relayMode() to always return SingleThread
so it stays as TEST_F without GetParam() UB.

MoqxRelayTestModes.cpp is added only to moqx_relay_test (not the shared
fixture library) to avoid a GTest warning in moqx_track_filter_test.



This change is Reviewable

Converts all MoQRelayTest TEST_F cases to TEST_P and instantiates them
under AllModes/MoQRelayTest with named variants (SingleThread, MultiThread).

MoqxTrackFilterTest overrides relayMode() to always return SingleThread
so it stays as TEST_F without GetParam() UB.

MoqxRelayTestModes.cpp is added only to moqx_relay_test (not the shared
fixture library) to avoid a GTest warning in moqx_track_filter_test.
@afrind afrind merged commit 3b8ee7d into main Jun 1, 2026
26 of 27 checks passed
@afrind afrind deleted the pr360 branch June 1, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants