install-system-deps: add python3 (fix bookworm publish jobs)#243
Merged
Conversation
proxygen's CMake configure runs find_program(PROXYGEN_PYTHON python3)
and fatal-errors if absent ("python is required for the proxygen
build"). python3 was previously satisfied transitively by
libboost-all-dev; narrowing to specific Boost components dropped it,
breaking Configure on the minimal debian:bookworm publish containers
(amd64 + arm64). Hosted ubuntu-22.04 runners ship python3, so they
were unaffected and masked the gap.
Add python3 explicitly to both the Ubuntu/Debian and Fedora installs.
gmarzot
requested review from
Oxyd,
TimEvens,
afrind,
akash-a-n,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
suhasHere
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
publish (bookworm-amd64)andpublish (bookworm-arm64)jobs fail at the Configure step:```
CMake Error at /cache/_deps/proxygen-src/CMakeLists.txt:66 (message):
python is required for the proxygen build
```
proxygen's configure runs
find_program(PROXYGEN_PYTHON python3)and fatal-errors when nopython3is on PATH. Until recently,python3arrived transitively vialibboost-all-dev. Narrowing the install to the specific Boost components the build actually links (#233) dropped that transitive dependency.The bookworm publish targets build inside a minimal
debian:bookwormcontainer whose base deps don't include python3, so Configure dies before the build starts. The hostedubuntu-22.04runners ship python3 preinstalled, which is why they kept passing and masked the gap.Fix
Add
python3explicitly to the Ubuntu/Debian and Fedora installs instandalone/install-system-deps.sh. It's a build-time tool requirement (alongsidegperf, already present), not a runtime link dependency.This change is