RA-429 : create a class that produces the administration notification…#50
RA-429 : create a class that produces the administration notification…#50mozzy11 wants to merge 1 commit intoopenmrs:masterfrom
Conversation
|
@mozzy11 , thank you for the good work. Where could the second bullet on the tickets acceptance criteria have been addressed in this pull request? |
|
@Ruhanga thank you for the comment, This PR creates an Administration Notification to the Administrator showing them that Duplicate concepts exists, and it directs them to upgrade to the metada module which contains the clean-up liquibase changeset |
|
sorry it was an error , i closd the PR accidentally |
...mrs/module/referenceapplication/administrativenotification/DuplicateConceptNotification.java
Show resolved
Hide resolved
| Integer concept1 = Context.getConceptService().getConcept(1).getConceptId(); | ||
| Integer concept2 = Context.getConceptService().getConcept(2).getConceptId(); | ||
| }catch (NullPointerException e) { | ||
| return null; |
There was a problem hiding this comment.
Why would you wait to first get a NPE?
There was a problem hiding this comment.
ok , let me try avoiding that.
… when duplicate concepts exists and AddedUnit Test m
| if( Context.getConceptService().getConcept(1)==null || Context.getConceptService().getConcept(2)==null | ||
| ) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
condition on line 29 and line 38 can me merged into a single if statement instead of using two if statements
There was a problem hiding this comment.
@mozzy11 could respond to @haripriya999 comment please
5 participants
https://issues.openmrs.org/browse/RA-429
The Administration Notification is only produced when duplicate concepts exists