Conversation
mogoodrich
left a comment
mogoodrich
left a comment
There was a problem hiding this comment.
Not sure exactly what the process registered variable is used for without seeing further code, but I trust you!
I was hoping a bit that you would sanity check me on this one. |
|
Okay, will do! @mseaton |
mogoodrich
left a comment
mogoodrich
left a comment
There was a problem hiding this comment.
See updated thoughts @mseaton
| if (record == null || expected == null || !expected.equals(tx)) { | ||
| throw new IllegalStateException("Ending transaction did not find the expected transaction on the stack"); | ||
| } | ||
| syncRecordThreadLocal.get().setProcessRegistered(tx, false); |
There was a problem hiding this comment.
processRegistered is a thread local variable that is used to record if a transaction has been to be registered on a current thread, and this changes things so that when we end a transaction instead of just setting the that the key-value to false it removes that record entirely? It also makes sure the transaction gets removed in case of n error case? This all makes sense.
2 participants
…the interceptor