fix: cache handler patch not matching require.resolve#1
Closed
james-elicx wants to merge 1 commit into
Closed
Conversation
17d57ec to
132922a
Compare
132922a to
db9b613
Compare
commit: |
Contributor
|
Is this really required for the adapters API? We used to do that to override the cache handler. |
Contributor
|
I'm not against merging that if it helps for now but there should be a follow up issue to clean that up. But I think this is already handled at https://github.com/opennextjs/opennextjs-cloudflare/blob/adapters-api/packages/cloudflare/src/cli/adapter.ts#L80 |
Collaborator
Author
|
To be honest I didn't go far enough to check that, it was just from when I was seeing if the e2es still ran with no changes. I'll close this if the thinking is that cache handler will no longer be an issue once adapters api is used properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the the adapters api
fixRequirepatch is applied,__requireis replaced withrequire, which results in the patch to replace the cache handler paths failing to match.