fix plot warning (#7)#8
Open
ahrensmaike wants to merge 1 commit into
Open
Conversation
* adding test fixture as suggestion * update plot tests, add snapshot * use_tidy_description() * Increment version number to 1.0.0.9000 * final plot adaptions - minor tickmarks for x and y axis - plot conditional an ggplot2 version --------- Co-authored-by: svoss09 <sebastian.voss.ext@bayer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at eliminating the warning about coloring stable variable names in red and improving the test suite for the plot.
For more recent ggplot2 version, this is done using
{ggtext}package, for older ones (pre 2024) color highlighting is replaced by highlighting variables with "*" (with a message). PR adds a snapshot for easier tracking and reviewing plot changes.Details are as follows:
Plotting
plot.variable.selectionsfunction now provides improved clustered heatmaps with colored variable labels (usingggtext::element_markdown()) to highlight stable selections in red forggplot2 >= 3.5.0, and falls back to asterisk-marked labels for older versions. The plotting logic is more robust, extended input validation and additional messages.draw_plot,variable_colored_label) to prevent R CMD check warnings.Testing
tests/testthat/fixtures/create_test_data.R) for reproducible and deterministic test data to speed up tests (currently not used, let's discuss)plot.variable.selections, including checks for errors on invalid input, correct class of plot output, and visual regression testing usingvdiffr.Package Metadata and Maintenance
DESCRIPTIONfile: incremented the version to1.0.0.9000, reorganized and expanded package dependencies, added a package URL, and improved formatting for clarity and maintainability (usethis::use_tidy_description()).co-authored by Sebastian Voss @svoss09 sebastian.voss.ext@bayer.com