Merged
Conversation
- Implement asset transfer service with balance checks and transaction handling - Add controller endpoints for creating and querying transfer records - Include DTOs for request/response and error constants - Add model for tracking transfer logs and user balances
…andling - Remove FromUser from request DTO and use authenticated user's wallet - Simplify user lookup logic by removing unnecessary user creation - Add automatic transfer failure marking on balance update errors - Normalize asset names to uppercase - Remove redundant timestamp fields from transfer log
…tency Ensure asset names are consistently handled in uppercase across all operations to prevent case sensitivity issues in database queries and updates.
Validate target user wallet before transfer and format both source and target wallets using common utilities to ensure consistency and prevent invalid transfers.
- Add SeeUsedAmount field to TreasuryAssetsResponse struct - Introduce AssetPrefixUSD constant for USD asset prefix - Update asset name checks to use constants instead of hardcoded strings - Include SEE asset in used amount calculations
Contributor
|
1 |
CooCoode
reviewed
Aug 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles those requirements
The changes contain proposal, treasury and other related logics