Fix issue with expr-matches and tuples with numpy arrays#106
Merged
PhilReinhold merged 2 commits intomainfrom Feb 24, 2026
Merged
Fix issue with expr-matches and tuples with numpy arrays#106PhilReinhold merged 2 commits intomainfrom
PhilReinhold merged 2 commits intomainfrom
Conversation
braised-babbage
approved these changes
Feb 24, 2026
Contributor
braised-babbage
left a comment
braised-babbage
left a comment
There was a problem hiding this comment.
Makes sense. Thanks for adding the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
expr_matchesroutine can produce a failure if numpy data is inside a tuple. Currently, tuples are compared by equality, and if the tuple contains a numpy array, this can result in numpy arrays being compared by equality, which produces an array rather than a bool.