Merged
Conversation
Contributor
braised-babbage
left a comment
braised-babbage
left a comment
There was a problem hiding this comment.
Looks good to me. One possible tweak suggested (hard to tell from here whether this matters).
|
|
||
| # Automatically handle Duration array. | ||
| if base_type is DurationVar and kwargs["init_expression"] is not None: | ||
| init = kwargs["init_expression"] |
Contributor
There was a problem hiding this comment.
Wondering whether this should be kwargs.get("init_expression"). Basically we could have a KeyError now since previously the and would short circuit when base_type is DurationVar was false.
Contributor
Author
There was a problem hiding this comment.
I see, I can update that. I also want to make sure that it's clear what is owned by "init_expression" and what args is doing here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following bug fixes:
"input"from float to durationand adds tests