Add jakarta.annotation-api dependency when using javax.annotation #972
+77
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AddDependencyrecipe toJavaxAnnotationMigrationToJakartaAnnotationto addjakarta.annotation:jakarta.annotation-apiwhenjavax.annotation.*classes are in useProblem
When migrating from
javax.annotationtojakarta.annotation, the recipe was only changing/upgrading the dependency if it already existed explicitly. If thejavax.annotationclasses (like@Priority) were available transitively, the migration would change the import statements but not add thejakarta.annotation-apidependency, causing compilation failures.This is inconsistent with how other migration recipes (like
JavaxMailToJakartaMail,JavaxServletToJakartaServlet,JavaxWsToJakartaWs) handle this scenario - they all include anAddDependencyrecipe withonlyIfUsingto ensure the dependency is present.Solution
Added
AddDependencyrecipe toJavaxAnnotationMigrationToJakartaAnnotation:Test plan
Existing tests pass
New test added for the transitive dependency scenario
Fixes moderneinc/customer-requests#1563