Add com.sun.istack.NotNull migration to Jakarta validation #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…migration This adds a ChangeType to the JavaxValidationMigrationToJakartaValidation recipe to migrate usages of the internal Sun JAXB annotation @com.sun.istack.NotNull to @jakarta.validation.constraints.NotNull. This addresses the third sub-issue in customer-requests#1526 where SpringBoot upgrade migrations were leaving com.sun.istack.NotNull imports unchanged, causing compilation errors. Fixes: moderneinc/customer-requests#1526
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
...va/org/openrewrite/java/migrate/jakarta/JavaxValidationMigrationToJakartaValidationTest.java
Show resolved
Hide resolved
...va/org/openrewrite/java/migrate/jakarta/JavaxValidationMigrationToJakartaValidationTest.java
Show resolved
Hide resolved
...va/org/openrewrite/java/migrate/jakarta/JavaxValidationMigrationToJakartaValidationTest.java
Show resolved
Hide resolved
...va/org/openrewrite/java/migrate/jakarta/JavaxValidationMigrationToJakartaValidationTest.java
Show resolved
Hide resolved
...va/org/openrewrite/java/migrate/jakarta/JavaxValidationMigrationToJakartaValidationTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ChangeTypeto migratecom.sun.istack.NotNull→jakarta.validation.constraints.NotNullMotivation
com.sun.istack.NotNullimports unchanged, causing compilation errors.The
com.sun.istack.NotNullannotation is an internal Sun JAXB implementation annotation that developers sometimes used inadvertently. When migrating to Jakarta EE, this annotation needs to be replaced with the standard@jakarta.validation.constraints.NotNull.Test plan
JavaxValidationMigrationToJakartaValidationTestcom.sun.istack.NotNull→jakarta.validation.constraints.NotNulljavax.validation→jakarta.validationmigration still works