Fix FinalizePrivateFields breaking code with lambda reads in field initializers#862
Merged
Fix FinalizePrivateFields breaking code with lambda reads in field initializers#862
Conversation
…a lambda initializer Skip private fields whose only assignment is in the constructor body when they are read inside a lambda or anonymous class in an instance field initializer or instance initializer block. Since initializers run before the constructor body, finalizing such fields breaks javac's definite assignment analysis. Fixes #861
steve-aom-elliott
approved these changes
Apr 17, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip finalizing private fields whose only assignment is in the constructor body when they are read inside a lambda or anonymous class in an instance field initializer or instance initializer block. Initializers run before the constructor, so finalizing such fields would break javac's definite assignment analysis.
Fixes
FinalizePrivateFieldsproduces uncompilable code when field is captured by a lambda in an instance field initializer #861Test plan
fieldReadByLambdaInInstanceFieldInitializerreproducing the issue's exact examplefieldReadByAnonymousClassInInstanceFieldInitializercovering anonymous class bodiesFinalizePrivateFieldsTestcases continue to pass