Integrate rust xacro #1#130
Draft
kaidokert wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey - here's a draft PR that would integrate Rust
xacro-rsfor parsing Xacro, and would do away with any direct Python/ROS dependencies completely.I've tested this on multiple platforms with an extensive libraries of files - it's working quite well, with urdf-viz.
For a demo, i just added a feature gate, but this could also be re-factored so it falls back to Python xacro, or prefers python - or does either based on runtime flag.
Any interest in building this in ?